Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for union types #68

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Adds support for union types #68

merged 2 commits into from
Apr 19, 2021

Conversation

cfroystad
Copy link
Collaborator

rfc

Since we already have a concept of type_list, I reused this node instad of exposing the union type. Feel free to voice any disagreements on this 🙂

@cfroystad cfroystad mentioned this pull request Apr 17, 2021
Closed
32 tasks
@patrickt
Copy link
Contributor

patrickt commented Apr 19, 2021 •
edited
Loading

Looks good to me, but are there any tests that exercise this path specifically? (Sorry, I don't know PHP, so I might be missing something.)

@cfroystad
Copy link
Collaborator Author

Good catch! For some mysterious reason I forgot to commit it, but it's added now

@patrickt patrickt merged commit 4dcc061 into tree-sitter:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cfroystad @patrickt